media: mtk-vcodec: potential null pointer deference in SCP

Fullway Wang · mchehab · commit 53dbe0850444 · 2024-05-03T07:06:51.000+01:00
The return value of devm_kzalloc() needs to be checked to avoid NULL pointer deference. This is similar to CVE-2022-3113. Link: https://lore.kernel.org/linux-media/PH7PR20MB5925094DAE3FD750C7E39E01BF712@PH7PR20MB5925.namprd20.prod.outlook.com Signed-off-by: Fullway Wang <fullwaywang@outlook.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c
@@ -79,6 +79,8 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_scp_init(void *priv, enum mtk_vcodec_fw_use
 	}
 
 	fw = devm_kzalloc(&plat_dev->dev, sizeof(*fw), GFP_KERNEL);
+	if (!fw)
+		return ERR_PTR(-ENOMEM);
 	fw->type = SCP;
 	fw->ops = &mtk_vcodec_rproc_msg;
 	fw->scp = scp;

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,8 @@ struct mtk_vcodec_fw mtk_vcodec_fw_scp_init(void priv, enum mtk_vcodec_fw_use`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`fw = devm_kzalloc(&plat_dev->dev, sizeof(*fw), GFP_KERNEL);`
	`82`	`+ if (!fw)`
	`83`	`+ return ERR_PTR(-ENOMEM);`
`82`	`84`	`fw->type = SCP;`
`83`	`85`	`fw->ops = &mtk_vcodec_rproc_msg;`
`84`	`86`	`fw->scp = scp;`