block: don't clear REQ_ALLOC_CACHE for non-polled requests

axboe · axboe · commit 53eab8e76667 · 2022-12-16T09:18:09.000-07:00
Since commit: b99182c ("bio: add pcpu caching for non-polling bio_put") we support bio caching for IRQ based IO as well, hence there's no need to manually clear REQ_ALLOC_CACHE if we disable polling on a request. Reviewed-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/include/linux/bio.h b/include/linux/bio.h
@@ -782,8 +782,7 @@ static inline void bio_set_polled(struct bio *bio, struct kiocb *kiocb)
 
 static inline void bio_clear_polled(struct bio *bio)
 {
-	/* can't support alloc cache if we turn off polling */
-	bio->bi_opf &= ~(REQ_POLLED | REQ_ALLOC_CACHE);
+	bio->bi_opf &= ~REQ_POLLED;
 }
 
 struct bio *blk_next_bio(struct bio *bio, struct block_device *bdev,

Original file line number	Diff line number	Diff line change
`@@ -782,8 +782,7 @@ static inline void bio_set_polled(struct bio bio, struct kiocb kiocb)`
`782`	`782`
`783`	`783`	`static inline void bio_clear_polled(struct bio *bio)`
`784`	`784`	`{`
`785`		`- /* can't support alloc cache if we turn off polling */`
`786`		`- bio->bi_opf &= ~(REQ_POLLED \| REQ_ALLOC_CACHE);`
	`785`	`+ bio->bi_opf &= ~REQ_POLLED;`
`787`	`786`	`}`
`788`	`787`
`789`	`788`	`struct bio blk_next_bio(struct bio bio, struct block_device *bdev,`