Skip to content

Commit 53eeb07

Browse files
author
Prashant Malani
committed
platform/chrome: cros_ec_typec: Make try power role optional
Some boards prefer not to specify a try-power-role. Update the port property parsing logic to not error out in case a try-power-role is not specified. Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Prashant Malani <pmalani@chromium.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/chrome-platform/20220127191659.3560810-1-pmalani@chromium.org/
1 parent 664de6a commit 53eeb07

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

drivers/platform/chrome/cros_ec_typec.c

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,18 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
115115
return ret;
116116
cap->data = ret;
117117

118+
/* Try-power-role is optional. */
118119
ret = fwnode_property_read_string(fwnode, "try-power-role", &buf);
119120
if (ret) {
120-
dev_err(dev, "try-power-role not found: %d\n", ret);
121-
return ret;
121+
dev_warn(dev, "try-power-role not found: %d\n", ret);
122+
cap->prefer_role = TYPEC_NO_PREFERRED_ROLE;
123+
} else {
124+
ret = typec_find_power_role(buf);
125+
if (ret < 0)
126+
return ret;
127+
cap->prefer_role = ret;
122128
}
123129

124-
ret = typec_find_power_role(buf);
125-
if (ret < 0)
126-
return ret;
127-
cap->prefer_role = ret;
128-
129130
cap->fwnode = fwnode;
130131

131132
return 0;

0 commit comments

Comments
 (0)