Skip to content

Commit 5497ffe

Browse files
Ondrej Jirmanmmind
authored andcommitted
arm64: dts: rockchip: Fix voltage threshold for volume keys for Pinephone Pro
Previously sometimes pressing the volume-down button would register as a volume-up button. Match the thresholds as shown in the Pinephone Pro schematic. Tests: ~ $ evtest // Mashed the volume down ~100 times with varying intensity Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1 Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0 // Mashed the volume up ~100 times with varying intensity Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1 Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0 Fixes: d3150ed ("arm64: dts: rockchip: Add support for volume keys to rk3399-pinephone-pro") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Jirman <megi@xff.cz> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> Reviewed-by: Pavel Machek <pavel@ucw.cz> Link: https://patch.msgid.link/20251124-ppp_light_accel_mag_vol-down-v5-4-f9a10a0a50eb@gmail.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 8f0b4cc commit 5497ffe

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@
4040
button-up {
4141
label = "Volume Up";
4242
linux,code = <KEY_VOLUMEUP>;
43-
press-threshold-microvolt = <100000>;
43+
press-threshold-microvolt = <2000>;
4444
};
4545

4646
button-down {
4747
label = "Volume Down";
4848
linux,code = <KEY_VOLUMEDOWN>;
49-
press-threshold-microvolt = <600000>;
49+
press-threshold-microvolt = <300000>;
5050
};
5151
};
5252

0 commit comments

Comments
 (0)