Skip to content

Commit 549bf94

Browse files
kwilczynskiLorenzo Pieralisi
authored andcommitted
PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. This change is as per suggestions from Coccinelle, e.g., drivers/pci/controller/dwc/pcie-qcom-ep.c:556:2-9: line 556 is redundant because platform_get_irq() already prints an error Related: https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/ https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/ Link: https://lore.kernel.org/r/20211027112931.37182-1-kw@linux.com Signed-off-by: Krzysztof Wilczyński <kw@linux.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 6e5ebc9 commit 549bf94

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -552,10 +552,8 @@ static int qcom_pcie_ep_enable_irq_resources(struct platform_device *pdev,
552552
int irq, ret;
553553

554554
irq = platform_get_irq_byname(pdev, "global");
555-
if (irq < 0) {
556-
dev_err(&pdev->dev, "Failed to get Global IRQ\n");
555+
if (irq < 0)
557556
return irq;
558-
}
559557

560558
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
561559
qcom_pcie_ep_global_irq_thread,

0 commit comments

Comments
 (0)