Skip to content

Commit 5551b02

Browse files
YunJe Shinrleon
authored andcommitted
RDMA/umad: Reject negative data_len in ib_umad_write
ib_umad_write computes data_len from user-controlled count and the MAD header sizes. With a mismatched user MAD header size and RMPP header length, data_len can become negative and reach ib_create_send_mad(). This can make the padding calculation exceed the segment size and trigger an out-of-bounds memset in alloc_send_rmpp_list(). Add an explicit check to reject negative data_len before creating the send buffer. KASAN splat: [ 211.363464] BUG: KASAN: slab-out-of-bounds in ib_create_send_mad+0xa01/0x11b0 [ 211.364077] Write of size 220 at addr ffff88800c3fa1f8 by task spray_thread/102 [ 211.365867] ib_create_send_mad+0xa01/0x11b0 [ 211.365887] ib_umad_write+0x853/0x1c80 Fixes: 2be8e3e ("IB/umad: Add P_Key index support") Signed-off-by: YunJe Shin <ioerts@kookmin.ac.kr> Link: https://patch.msgid.link/20260203100628.1215408-1-ioerts@kookmin.ac.kr Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent 42e3aac commit 5551b02

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/infiniband/core/user_mad.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,8 @@ static ssize_t ib_umad_write(struct file *filp, const char __user *buf,
514514
struct rdma_ah_attr ah_attr;
515515
struct ib_ah *ah;
516516
__be64 *tid;
517-
int ret, data_len, hdr_len, copy_offset, rmpp_active;
517+
int ret, hdr_len, copy_offset, rmpp_active;
518+
size_t data_len;
518519
u8 base_version;
519520

520521
if (count < hdr_size(file) + IB_MGMT_RMPP_HDR)
@@ -588,7 +589,10 @@ static ssize_t ib_umad_write(struct file *filp, const char __user *buf,
588589
}
589590

590591
base_version = ((struct ib_mad_hdr *)&packet->mad.data)->base_version;
591-
data_len = count - hdr_size(file) - hdr_len;
592+
if (check_sub_overflow(count, hdr_size(file) + hdr_len, &data_len)) {
593+
ret = -EINVAL;
594+
goto err_ah;
595+
}
592596
packet->msg = ib_create_send_mad(agent,
593597
be32_to_cpu(packet->mad.hdr.qpn),
594598
packet->mad.hdr.pkey_index, rmpp_active,

0 commit comments

Comments
 (0)