Skip to content

Commit 55650b2

Browse files
aweeramanbrauner
authored andcommitted
fs/open.c: Fix W=1 kernel doc warnings
fs/open.c: In functions 'setattr_vfsuid' and 'setattr_vfsgid': warning: Function parameter or member 'attr' not described - Fix warning by removing kernel-doc for these as they are static inline functions and not required to be exposed via kernel-doc. fs/open.c: warning: Excess function parameter 'opened' description in 'finish_open' warning: Excess function parameter 'cred' description in 'vfs_open' - Fix by removing the parameters from the kernel-doc as they are no longer required by the function. Signed-off-by: Anuradha Weeraman <anuradha@debian.org> Message-Id: <20230506182928.384105-1-anuradha@debian.org> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent c642256 commit 55650b2

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

fs/open.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -700,10 +700,7 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, umode_t, mode)
700700
return do_fchmodat(AT_FDCWD, filename, mode);
701701
}
702702

703-
/**
704-
* setattr_vfsuid - check and set ia_fsuid attribute
705-
* @kuid: new inode owner
706-
*
703+
/*
707704
* Check whether @kuid is valid and if so generate and set vfsuid_t in
708705
* ia_vfsuid.
709706
*
@@ -718,10 +715,7 @@ static inline bool setattr_vfsuid(struct iattr *attr, kuid_t kuid)
718715
return true;
719716
}
720717

721-
/**
722-
* setattr_vfsgid - check and set ia_fsgid attribute
723-
* @kgid: new inode owner
724-
*
718+
/*
725719
* Check whether @kgid is valid and if so generate and set vfsgid_t in
726720
* ia_vfsgid.
727721
*
@@ -989,7 +983,6 @@ static int do_dentry_open(struct file *f,
989983
* @file: file pointer
990984
* @dentry: pointer to dentry
991985
* @open: open callback
992-
* @opened: state of open
993986
*
994987
* This can be used to finish opening a file passed to i_op->atomic_open().
995988
*
@@ -1043,7 +1036,6 @@ EXPORT_SYMBOL(file_path);
10431036
* vfs_open - open the file at the given path
10441037
* @path: path to open
10451038
* @file: newly allocated file with f_flag initialized
1046-
* @cred: credentials to use
10471039
*/
10481040
int vfs_open(const struct path *path, struct file *file)
10491041
{

0 commit comments

Comments
 (0)