Skip to content

Commit 5565a8e

Browse files
azeemshaikh38sumitsemwal
authored andcommitted
dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230523021943.2406847-1-azeemshaikh38@gmail.com
1 parent 6a038f0 commit 5565a8e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/dma-buf/sw_sync.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static struct sync_timeline *sync_timeline_create(const char *name)
8585

8686
kref_init(&obj->kref);
8787
obj->context = dma_fence_context_alloc(1);
88-
strlcpy(obj->name, name, sizeof(obj->name));
88+
strscpy(obj->name, name, sizeof(obj->name));
8989

9090
obj->pt_tree = RB_ROOT;
9191
INIT_LIST_HEAD(&obj->pt_list);

0 commit comments

Comments
 (0)