Skip to content

Commit 5568f64

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
thermal: imx8mm: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 6abe2f0 commit 5568f64

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/thermal/imx8mm_thermal.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ static int imx8mm_tmu_probe(struct platform_device *pdev)
363363
return ret;
364364
}
365365

366-
static int imx8mm_tmu_remove(struct platform_device *pdev)
366+
static void imx8mm_tmu_remove(struct platform_device *pdev)
367367
{
368368
struct imx8mm_tmu *tmu = platform_get_drvdata(pdev);
369369

@@ -372,8 +372,6 @@ static int imx8mm_tmu_remove(struct platform_device *pdev)
372372

373373
clk_disable_unprepare(tmu->clk);
374374
platform_set_drvdata(pdev, NULL);
375-
376-
return 0;
377375
}
378376

379377
static struct thermal_soc_data imx8mm_tmu_data = {
@@ -401,7 +399,7 @@ static struct platform_driver imx8mm_tmu = {
401399
.of_match_table = imx8mm_tmu_table,
402400
},
403401
.probe = imx8mm_tmu_probe,
404-
.remove = imx8mm_tmu_remove,
402+
.remove_new = imx8mm_tmu_remove,
405403
};
406404
module_platform_driver(imx8mm_tmu);
407405

0 commit comments

Comments
 (0)