Skip to content

Commit 55a8b42

Browse files
SinkFinderbroonie
authored andcommitted
spi: altera: Fix memory leak on error path
Release master that have been previously allocated if the number of chipselect is invalid. Fixes: 8e04187 ("spi: altera: add SPI core parameters support via platform data.") Signed-off-by: Pan Bian <bianpan2016@163.com> Reviewed-by: Tom Rix <trix@redhat.com> Link: https://lore.kernel.org/r/20210120082635.49304-1-bianpan2016@163.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 4d163ad commit 55a8b42

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/spi/spi-altera.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,8 @@ static int altera_spi_probe(struct platform_device *pdev)
254254
dev_err(&pdev->dev,
255255
"Invalid number of chipselect: %hu\n",
256256
pdata->num_chipselect);
257-
return -EINVAL;
257+
err = -EINVAL;
258+
goto exit;
258259
}
259260

260261
master->num_chipselect = pdata->num_chipselect;

0 commit comments

Comments
 (0)