Skip to content

Commit 55e3918

Browse files
namhyungacmel
authored andcommitted
perf lock contention: Fix to save callstack for the default modified
The previous change missed to set the con->save_callstack for the LOCK_AGGR_CALLER mode resulting in no caller information. Fixes: ebab291 ("perf lock contention: Support filters for different aggregation") Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Boqun Feng <boqun.feng@gmail.com> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Hao Luo <haoluo@google.com> Cc: Ian Rogers <irogers@google.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Song Liu <song@kernel.org> Cc: Waiman Long <longman@redhat.com> Cc: Will Deacon <will@kernel.org> Cc: bpf@vger.kernel.org Link: https://lore.kernel.org/r/20230207002403.63590-2-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 34266f9 commit 55e3918

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

tools/perf/builtin-lock.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1806,6 +1806,9 @@ static int __cmd_contention(int argc, const char **argv)
18061806
con.aggr_mode = aggr_mode = show_thread_stats ? LOCK_AGGR_TASK :
18071807
show_lock_addrs ? LOCK_AGGR_ADDR : LOCK_AGGR_CALLER;
18081808

1809+
if (con.aggr_mode == LOCK_AGGR_CALLER)
1810+
con.save_callstack = true;
1811+
18091812
/* for lock function check */
18101813
symbol_conf.sort_by_name = true;
18111814
symbol_conf.allow_aliases = true;

0 commit comments

Comments
 (0)