btrfs: tests: fix double btrfs_path free in remove_extent_ref()

Dan Carpenter · kdave · commit 564d59410c39 · 2025-12-08T21:46:43.000+01:00
We converted this code to use auto free cleanup.h magic but one remaining free was accidentally left behind which leads to a double free bug. Fixes: a320476 ("btrfs: tests: do trivial BTRFS_PATH_AUTO_FREE conversions") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/tests/qgroup-tests.c b/fs/btrfs/tests/qgroup-tests.c
@@ -187,7 +187,6 @@ static int remove_extent_ref(struct btrfs_root *root, u64 bytenr,
 	ret = btrfs_search_slot(&trans, root, &key, path, -1, 1);
 	if (ret) {
 		test_err("couldn't find backref %d", ret);
-		btrfs_free_path(path);
 		return ret;
 	}
 	btrfs_del_item(&trans, root, path);

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,6 @@ static int remove_extent_ref(struct btrfs_root *root, u64 bytenr,`
`187`	`187`	`ret = btrfs_search_slot(&trans, root, &key, path, -1, 1);`
`188`	`188`	`if (ret) {`
`189`	`189`	`test_err("couldn't find backref %d", ret);`
`190`		`- btrfs_free_path(path);`
`191`	`190`	`return ret;`
`192`	`191`	`}`
`193`	`192`	`btrfs_del_item(&trans, root, path);`