Skip to content

Commit 5666a27

Browse files
committed
driver core: fix driver_set_override() issue with empty strings
Python likes to send an empty string for some sysfs files, including the driver_override field. When commit 23d99ba ("PCI: Use driver_set_override() instead of open-coding") moved the PCI core to use the driver core function instead of hand-rolling their own handler, this showed up as a regression from some userspace tools, like DPDK. Fix this up by actually looking at the length of the string first instead of trusting that userspace got it correct. Fixes: 23d99ba ("PCI: Use driver_set_override() instead of open-coding") Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: stable <stable@kernel.org> Reported-by: Stephen Hemminger <stephen@networkplumber.org> Tested-by: Huisong Li <lihuisong@huawei.com> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220901163734.3583106-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c749b27 commit 5666a27

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/base/driver.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ int driver_set_override(struct device *dev, const char **override,
6363
if (len >= (PAGE_SIZE - 1))
6464
return -EINVAL;
6565

66+
/*
67+
* Compute the real length of the string in case userspace sends us a
68+
* bunch of \0 characters like python likes to do.
69+
*/
70+
len = strlen(s);
71+
6672
if (!len) {
6773
/* Empty string passed - clear override */
6874
device_lock(dev);

0 commit comments

Comments
 (0)