Skip to content

Commit 56c1cfb

Browse files
committed
clk: versaclock3: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 9e3372b ("clk: versaclock3: convert from round_rate() to determine_rate()") Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent 2532795 commit 56c1cfb

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/clk/clk-versaclock3.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -523,11 +523,8 @@ static int vc3_div_determine_rate(struct clk_hw *hw,
523523
return 0;
524524
}
525525

526-
req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
527-
div_data->table,
528-
div_data->width, div_data->flags);
529-
530-
return 0;
526+
return divider_determine_rate(hw, req, div_data->table, div_data->width,
527+
div_data->flags);
531528
}
532529

533530
static int vc3_div_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)