Skip to content

Commit 5714ee5

Browse files
KevinBuettnertorvalds
authored andcommitted
copy_xstate_to_kernel: Fix typo which caused GDB regression
This fixes a regression encountered while running the gdb.base/corefile.exp test in GDB's test suite. In my testing, the typo prevented the sw_reserved field of struct fxregs_state from being output to the kernel XSAVES area. Thus the correct mask corresponding to XCR0 was not present in the core file for GDB to interrogate, resulting in the following behavior: [kev@f32-1 gdb]$ ./gdb -q testsuite/outputs/gdb.base/corefile/corefile testsuite/outputs/gdb.base/corefile/corefile.core Reading symbols from testsuite/outputs/gdb.base/corefile/corefile... [New LWP 232880] warning: Unexpected size of section `.reg-xstate/232880' in core file. With the typo fixed, the test works again as expected. Signed-off-by: Kevin Buettner <kevinb@redhat.com> Fixes: 9e46365 ("copy_xstate_to_kernel(): don't leave parts of destination uninitialized") Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Dave Airlie <airlied@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ba47d84 commit 5714ee5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/kernel/fpu/xstate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,7 @@ int copy_xstate_to_kernel(void *kbuf, struct xregs_state *xsave, unsigned int of
10741074
copy_part(offsetof(struct fxregs_state, st_space), 128,
10751075
&xsave->i387.st_space, &kbuf, &offset_start, &count);
10761076
if (header.xfeatures & XFEATURE_MASK_SSE)
1077-
copy_part(xstate_offsets[XFEATURE_MASK_SSE], 256,
1077+
copy_part(xstate_offsets[XFEATURE_SSE], 256,
10781078
&xsave->i387.xmm_space, &kbuf, &offset_start, &count);
10791079
/*
10801080
* Fill xsave->i387.sw_reserved value for ptrace frame:

0 commit comments

Comments
 (0)