Skip to content

Commit 5733d13

Browse files
hkallweitkuba-moo
authored andcommitted
lan743x: remove redundant statement in lan743x_ethtool_get_eee
eee_active is set by phy_ethtool_get_eee() already, using the same logic plus an additional check against link speed/duplex values. See genphy_c45_eee_is_active() for details. So we can remove this line. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://lore.kernel.org/r/3340ff84-8d7a-404b-8268-732c7f281164@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1c835c8 commit 5733d13

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/net/ethernet/microchip/lan743x_ethtool.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1077,7 +1077,6 @@ static int lan743x_ethtool_get_eee(struct net_device *netdev,
10771077
buf = lan743x_csr_read(adapter, MAC_CR);
10781078
if (buf & MAC_CR_EEE_EN_) {
10791079
eee->eee_enabled = true;
1080-
eee->eee_active = !!(eee->advertised & eee->lp_advertised);
10811080
eee->tx_lpi_enabled = true;
10821081
/* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */
10831082
buf = lan743x_csr_read(adapter, MAC_EEE_TX_LPI_REQ_DLY_CNT);

0 commit comments

Comments
 (0)