xdrgen: Remove program_stat_to_errno() call sites

chucklever · chucklever · commit 573954a996c0 · 2024-11-18T20:23:07.000-05:00
Refactor: Translating an on-the-wire value to a local host errno is
architecturally a job for the proc function, not the XDR decoder.

Signed-off-by: Chuck Lever &lt;chuck.lever@oracle.com&gt;
diff --git a/tools/net/sunrpc/xdrgen/templates/C/program/decoder/result.j2 b/tools/net/sunrpc/xdrgen/templates/C/program/decoder/result.j2
@@ -13,8 +13,6 @@ static int {{ program }}_xdr_dec_{{ result }}(struct rpc_rqst *req,
 
 	if (!xdrgen_decode_{{ result }}(xdr, result))
 		return -EIO;
-	if (result->stat)
-		return {{ program }}_stat_to_errno(result->stat);
 {% endif %}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@ static int {{ program }}_xdr_dec_{{ result }}(struct rpc_rqst *req,`
`13`	`13`
`14`	`14`	`if (!xdrgen_decode_{{ result }}(xdr, result))`
`15`	`15`	`return -EIO;`
`16`		`- if (result->stat)`
`17`		`- return {{ program }}_stat_to_errno(result->stat);`
`18`	`16`	`{% endif %}`
`19`	`17`	`return 0;`
`20`	`18`	`}`