Skip to content

Commit 576892a

Browse files
ts-krisbrgl
authored andcommitted
gpio: ts4900: Fix comment formatting and grammar
The issues were pointed out after the prior commit was applied. Signed-off-by: Kris Bahnsen <kris@embeddedTS.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
1 parent f443e37 commit 576892a

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

drivers/gpio/gpio-ts4900.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
5555
{
5656
struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
5757

58-
/* Only clear the OE bit here, requires a RMW. Prevents potential issue
59-
* with OE and data getting to the physical pin at different times.
58+
/*
59+
* Only clear the OE bit here, requires a RMW. Prevents a potential issue
60+
* with OE and DAT getting to the physical pin at different times.
6061
*/
6162
return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
6263
}
@@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
6869
unsigned int reg;
6970
int ret;
7071

71-
/* If changing from an input to an output, we need to first set the
72-
* proper data bit to what is requested and then set OE bit. This
73-
* prevents a glitch that can occur on the IO line
72+
/*
73+
* If changing from an input to an output, we need to first set the
74+
* GPIO's DAT bit to what is requested and then set the OE bit. This
75+
* prevents a glitch that can occur on the IO line.
7476
*/
7577
regmap_read(priv->regmap, offset, &reg);
7678
if (!(reg & TS4900_GPIO_OE)) {

0 commit comments

Comments
 (0)