Skip to content

Commit 57925e1

Browse files
Rong ChenUlf Hansson
authored andcommitted
mmc: meson-gx: Remove setting of CMD_CFG_ERROR
For the t7 and older SoC families, the CMD_CFG_ERROR has no effect. Starting from SoC family C3, setting this bit without SG LINK data address will cause the controller to generate an IRQ and stop working. To fix it, don't set the bit CMD_CFG_ERROR anymore. Fixes: 18f92bc ("mmc: meson-gx: make sure the descriptor is stopped on errors") Signed-off-by: Rong Chen <rong.chen@amlogic.com> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20231026073156.2868310-1-rong.chen@amlogic.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 84ee19b commit 57925e1

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/mmc/host/meson-gx-mmc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
801801

802802
cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
803803
cmd_cfg |= CMD_CFG_OWNER; /* owned by CPU */
804-
cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
805804

806805
meson_mmc_set_response_bits(cmd, &cmd_cfg);
807806

0 commit comments

Comments
 (0)