staging: r8188eu: call _cancel_timer_ex from _rtw_free_recv_priv

MakwanaVihas · gregkh · commit 57a42b4d73f9 · 2022-03-15T15:18:20.000+01:00
The _rtw_init_recv_priv() initializes precvpriv->signal_stat_timer and sets it's timeout interval to 1000 ms. But _rtw_free_recv_priv() doesn't cancel the timer and we need to explicitly call _cancel_timer_ex() after we call _rtw_free_recv_priv() to cancel the timer. Call _cancel_timer_ex() from inside _rtw_free_recv_priv() as every init function needs a matching free function. Signed-off-by: Vihas Makwana <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220309205047.45981-2-makvihas@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -103,6 +103,7 @@ void _rtw_free_recv_priv(struct recv_priv *precvpriv)
 	vfree(precvpriv->pallocated_frame_buf);
 
 	rtl8188eu_free_recv_priv(padapter);
+	_cancel_timer_ex(&precvpriv->signal_stat_timer);
 }
 
 struct recv_frame *_rtw_alloc_recvframe(struct __queue *pfree_recv_queue)

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ void _rtw_free_recv_priv(struct recv_priv *precvpriv)`
`103`	`103`	`vfree(precvpriv->pallocated_frame_buf);`
`104`	`104`
`105`	`105`	`rtl8188eu_free_recv_priv(padapter);`
	`106`	`+ _cancel_timer_ex(&precvpriv->signal_stat_timer);`
`106`	`107`	`}`
`107`	`108`
`108`	`109`	`struct recv_frame _rtw_alloc_recvframe(struct __queue pfree_recv_queue)`