Skip to content

Commit 57bb13d

Browse files
aloktiwakuba-moo
authored andcommitted
iavf: clarify VLAN add/delete log messages and lower log level
The current dev_warn messages for too many VLAN changes are confusing and one place incorrectly references "add" instead of "delete" VLANs due to copy-paste errors. - Use dev_info instead of dev_warn to lower the log level. - Rephrase the message to: "virtchnl: Too many VLAN [add|delete] ([v1|v2]) requests; splitting into multiple messages to PF\n". Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Link: https://patch.msgid.link/20251125223632.1857532-12-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1105a7a commit 57bb13d

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

drivers/net/ethernet/intel/iavf/iavf_virtchnl.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
793793

794794
len = virtchnl_struct_size(vvfl, vlan_id, count);
795795
if (len > IAVF_MAX_AQ_BUF_SIZE) {
796-
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
796+
dev_info(&adapter->pdev->dev,
797+
"virtchnl: Too many VLAN add (v1) requests; splitting into multiple messages to PF\n");
797798
while (len > IAVF_MAX_AQ_BUF_SIZE)
798799
len = virtchnl_struct_size(vvfl, vlan_id,
799800
--count);
@@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
838839

839840
len = virtchnl_struct_size(vvfl_v2, filters, count);
840841
if (len > IAVF_MAX_AQ_BUF_SIZE) {
841-
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
842+
dev_info(&adapter->pdev->dev,
843+
"virtchnl: Too many VLAN add (v2) requests; splitting into multiple messages to PF\n");
842844
while (len > IAVF_MAX_AQ_BUF_SIZE)
843845
len = virtchnl_struct_size(vvfl_v2, filters,
844846
--count);
@@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
941943

942944
len = virtchnl_struct_size(vvfl, vlan_id, count);
943945
if (len > IAVF_MAX_AQ_BUF_SIZE) {
944-
dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
946+
dev_info(&adapter->pdev->dev,
947+
"virtchnl: Too many VLAN delete (v1) requests; splitting into multiple messages to PF\n");
945948
while (len > IAVF_MAX_AQ_BUF_SIZE)
946949
len = virtchnl_struct_size(vvfl, vlan_id,
947950
--count);
@@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
987990

988991
len = virtchnl_struct_size(vvfl_v2, filters, count);
989992
if (len > IAVF_MAX_AQ_BUF_SIZE) {
990-
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
993+
dev_info(&adapter->pdev->dev,
994+
"virtchnl: Too many VLAN delete (v2) requests; splitting into multiple messages to PF\n");
991995
while (len > IAVF_MAX_AQ_BUF_SIZE)
992996
len = virtchnl_struct_size(vvfl_v2, filters,
993997
--count);

0 commit comments

Comments
 (0)