Skip to content

Commit 57d508b

Browse files
krzkbroonie
authored andcommitted
ASoC: rockchip: Fix Wvoid-pointer-to-enum-cast warning (again)
'version' is an enum, thus cast of pointer on 64-bit compile test with clang W=1 causes: rockchip_pdm.c:583:17: error: cast to smaller integer type 'enum rk_pdm_version' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] This was already fixed in commit 49a4a8d ("ASoC: rockchip: Fix Wvoid-pointer-to-enum-cast warning") but then got bad in commit 9958d85 ("ASoC: Use device_get_match_data()"). Discussion on LKML also pointed out that 'uintptr_t' is not the correct type and either 'kernel_ulong_t' or 'unsigned long' should be used, with several arguments towards the latter [1]. Link: https://lore.kernel.org/r/CAMuHMdX7t=mabqFE5O-Cii3REMuyaePHmqX+j_mqyrn6XXzsoA@mail.gmail.com/ [1] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Link: https://patch.msgid.link/20251203141644.106459-2-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 2c7e5e1 commit 57d508b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/rockchip/rockchip_pdm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ static int rockchip_pdm_probe(struct platform_device *pdev)
580580
if (!pdm)
581581
return -ENOMEM;
582582

583-
pdm->version = (enum rk_pdm_version)device_get_match_data(&pdev->dev);
583+
pdm->version = (unsigned long)device_get_match_data(&pdev->dev);
584584
if (pdm->version == RK_PDM_RK3308) {
585585
pdm->reset = devm_reset_control_get(&pdev->dev, "pdm-m");
586586
if (IS_ERR(pdm->reset))

0 commit comments

Comments
 (0)