Skip to content

Commit 57e0513

Browse files
chenhuacaiThomas Gleixner
authored andcommitted
irqchip/loongson-liointc: Adjust irqchip driver for 32BIT/64BIT
irq_domain_alloc_fwnode() takes a parameter with the phys_addr_t type. Currently the code passes acpi_liointc->address to it. This can only work on 64BIT platforms because its type is u64, so cast it to phys_addr_t and then the driver works on both 32BIT and 64BIT platform. [ tglx: Make the cast explicit and use the casted address as argument for liointc_init() which takes a phys_addr_t as well. Sigh... ] Co-developed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Link: https://patch.msgid.link/20260113085940.3344837-3-chenhuacai@loongson.cn
1 parent d9e7035 commit 57e0513

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/irqchip/irq-loongson-liointc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,23 +394,23 @@ static int __init acpi_cascade_irqdomain_init(void)
394394

395395
int __init liointc_acpi_init(struct irq_domain *parent, struct acpi_madt_lio_pic *acpi_liointc)
396396
{
397-
int ret;
397+
phys_addr_t addr = (phys_addr_t)acpi_liointc->address;
398398
struct fwnode_handle *domain_handle;
399+
int ret;
399400

400401
parent_int_map[0] = acpi_liointc->cascade_map[0];
401402
parent_int_map[1] = acpi_liointc->cascade_map[1];
402403

403404
parent_irq[0] = irq_create_mapping(parent, acpi_liointc->cascade[0]);
404405
parent_irq[1] = irq_create_mapping(parent, acpi_liointc->cascade[1]);
405406

406-
domain_handle = irq_domain_alloc_fwnode(&acpi_liointc->address);
407+
domain_handle = irq_domain_alloc_fwnode(&addr);
407408
if (!domain_handle) {
408409
pr_err("Unable to allocate domain handle\n");
409410
return -ENOMEM;
410411
}
411412

412-
ret = liointc_init(acpi_liointc->address, acpi_liointc->size,
413-
1, domain_handle, NULL);
413+
ret = liointc_init(addr, acpi_liointc->size, 1, domain_handle, NULL);
414414
if (ret == 0)
415415
ret = acpi_cascade_irqdomain_init();
416416
else

0 commit comments

Comments
 (0)