Skip to content

Commit 57e20d6

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: fixed-rate: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-11-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 6f149b6 commit 57e20d6

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clk/clk-fixed-rate.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,14 +196,12 @@ void __init of_fixed_clk_setup(struct device_node *node)
196196
}
197197
CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
198198

199-
static int of_fixed_clk_remove(struct platform_device *pdev)
199+
static void of_fixed_clk_remove(struct platform_device *pdev)
200200
{
201201
struct clk_hw *hw = platform_get_drvdata(pdev);
202202

203203
of_clk_del_provider(pdev->dev.of_node);
204204
clk_hw_unregister_fixed_rate(hw);
205-
206-
return 0;
207205
}
208206

209207
static int of_fixed_clk_probe(struct platform_device *pdev)
@@ -234,7 +232,7 @@ static struct platform_driver of_fixed_clk_driver = {
234232
.of_match_table = of_fixed_clk_ids,
235233
},
236234
.probe = of_fixed_clk_probe,
237-
.remove = of_fixed_clk_remove,
235+
.remove_new = of_fixed_clk_remove,
238236
};
239237
builtin_platform_driver(of_fixed_clk_driver);
240238
#endif

0 commit comments

Comments
 (0)