rcu: Uninline multi-use function: finish_rcuwait()

ingomolnar · paulmckrcu · commit 58d4292bd037 · 2022-02-14T10:36:58.000-08:00
This is a rarely used function, so uninlining its 3 instructions
is probably a win or a wash - but the main motivation is to
make &lt;linux/rcuwait.h&gt; independent of task_struct details.

Signed-off-by: Ingo Molnar &lt;mingo@kernel.org&gt;
Signed-off-by: Paul E. McKenney &lt;paulmck@kernel.org&gt;
diff --git a/include/linux/rcuwait.h b/include/linux/rcuwait.h
@@ -47,11 +47,7 @@ static inline void prepare_to_rcuwait(struct rcuwait *w)
 	rcu_assign_pointer(w->task, current);
 }
 
-static inline void finish_rcuwait(struct rcuwait *w)
-{
-        rcu_assign_pointer(w->task, NULL);
-	__set_current_state(TASK_RUNNING);
-}
+extern void finish_rcuwait(struct rcuwait *w);
 
 #define rcuwait_wait_event(w, condition, state)				\
 ({									\
diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
@@ -407,6 +407,13 @@ void __wait_rcu_gp(bool checktiny, int n, call_rcu_func_t *crcu_array,
 }
 EXPORT_SYMBOL_GPL(__wait_rcu_gp);
 
+void finish_rcuwait(struct rcuwait *w)
+{
+	rcu_assign_pointer(w->task, NULL);
+	__set_current_state(TASK_RUNNING);
+}
+EXPORT_SYMBOL_GPL(finish_rcuwait);
+
 #ifdef CONFIG_DEBUG_OBJECTS_RCU_HEAD
 void init_rcu_head(struct rcu_head *head)
 {

Original file line number	Diff line number	Diff line change
`@@ -407,6 +407,13 @@ void __wait_rcu_gp(bool checktiny, int n, call_rcu_func_t *crcu_array,`
`407`	`407`	`}`
`408`	`408`	`EXPORT_SYMBOL_GPL(__wait_rcu_gp);`
`409`	`409`
	`410`	`+void finish_rcuwait(struct rcuwait *w)`
	`411`	`+{`
	`412`	`+ rcu_assign_pointer(w->task, NULL);`
	`413`	`+ __set_current_state(TASK_RUNNING);`
	`414`	`+}`
	`415`	`+EXPORT_SYMBOL_GPL(finish_rcuwait);`
	`416`	`+`
`410`	`417`	`#ifdef CONFIG_DEBUG_OBJECTS_RCU_HEAD`
`411`	`418`	`void init_rcu_head(struct rcu_head *head)`
`412`	`419`	`{`