x86/microcode: Use the DEVICE_ATTR_RO() macro

huaidan2016 · ingomolnar · commit 59047d942bed · 2023-01-18T12:02:20.000+01:00
Use DEVICE_ATTR_RO() helper instead of open-coded DEVICE_ATTR(), which makes the code a bit shorter and easier to read. No change in functionality. Signed-off-by: Guangju Wang[baidu] <wgj900@163.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Acked-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20230118023554.1898-1-wgj900@163.com
diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
@@ -507,16 +507,16 @@ static ssize_t version_show(struct device *dev,
 	return sprintf(buf, "0x%x\n", uci->cpu_sig.rev);
 }
 
-static ssize_t pf_show(struct device *dev,
+static ssize_t processor_flags_show(struct device *dev,
 			struct device_attribute *attr, char *buf)
 {
 	struct ucode_cpu_info *uci = ucode_cpu_info + dev->id;
 
 	return sprintf(buf, "0x%x\n", uci->cpu_sig.pf);
 }
 
-static DEVICE_ATTR(version, 0444, version_show, NULL);
-static DEVICE_ATTR(processor_flags, 0444, pf_show, NULL);
+static DEVICE_ATTR_RO(version);
+static DEVICE_ATTR_RO(processor_flags);
 
 static struct attribute *mc_default_attrs[] = {
 	&dev_attr_version.attr,

Original file line number	Diff line number	Diff line change
`@@ -507,16 +507,16 @@ static ssize_t version_show(struct device *dev,`
`507`	`507`	`return sprintf(buf, "0x%x\n", uci->cpu_sig.rev);`
`508`	`508`	`}`
`509`	`509`
`510`		`-static ssize_t pf_show(struct device *dev,`
	`510`	`+static ssize_t processor_flags_show(struct device *dev,`
`511`	`511`	`struct device_attribute attr, char buf)`
`512`	`512`	`{`
`513`	`513`	`struct ucode_cpu_info *uci = ucode_cpu_info + dev->id;`
`514`	`514`
`515`	`515`	`return sprintf(buf, "0x%x\n", uci->cpu_sig.pf);`
`516`	`516`	`}`
`517`	`517`
`518`		`-static DEVICE_ATTR(version, 0444, version_show, NULL);`
`519`		`-static DEVICE_ATTR(processor_flags, 0444, pf_show, NULL);`
	`518`	`+static DEVICE_ATTR_RO(version);`
	`519`	`+static DEVICE_ATTR_RO(processor_flags);`
`520`	`520`
`521`	`521`	`static struct attribute *mc_default_attrs[] = {`
`522`	`522`	`&dev_attr_version.attr,`