smb: client: compress: fix a potential issue of freeing an invalid pointer

Qianqiang Liu · smfrench · commit 590efcd3c75f · 2024-09-15T10:42:45.000-05:00
The dst pointer may not be initialized when calling kvfree(dst) Fixes: 13b68d4 ("smb: client: compress: LZ77 code improvements cleanup") Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com> Signed-off-by: Steve French <stfrench@microsoft.com>
diff --git a/fs/smb/client/compress.c b/fs/smb/client/compress.c
@@ -318,7 +318,7 @@ int smb_compress(struct TCP_Server_Info *server, struct smb_rqst *rq, compress_s
 {
 	struct iov_iter iter;
 	u32 slen, dlen;
-	void *src, *dst;
+	void *src, *dst = NULL;
 	int ret;
 
 	if (!server || !rq || !rq->rq_iov || !rq->rq_iov->iov_base)

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ int smb_compress(struct TCP_Server_Info server, struct smb_rqst rq, compress_s`
`318`	`318`	`{`
`319`	`319`	`struct iov_iter iter;`
`320`	`320`	`u32 slen, dlen;`
`321`		`- void src, dst;`
	`321`	`+ void src, dst = NULL;`
`322`	`322`	`int ret;`
`323`	`323`
`324`	`324`	`if (!server \|\| !rq \|\| !rq->rq_iov \|\| !rq->rq_iov->iov_base)`