KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set

Maxim Levitsky · bonzini · commit 5959ff4ae96e · 2022-04-02T05:34:45.000-04:00
It makes more sense to print new SPTE value than the
old value.

Signed-off-by: Maxim Levitsky &lt;mlevitsk@redhat.com&gt;
Reviewed-by: Sean Christopherson &lt;seanjc@google.com&gt;
Message-Id: &lt;20220302102457.588450-1-mlevitsk@redhat.com&gt;
Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
@@ -2696,8 +2696,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct kvm_memory_slot *slot,
 	if (*sptep == spte) {
 		ret = RET_PF_SPURIOUS;
 	} else {
-		trace_kvm_mmu_set_spte(level, gfn, sptep);
 		flush |= mmu_spte_update(sptep, spte);
+		trace_kvm_mmu_set_spte(level, gfn, sptep);
 	}
 
 	if (wrprot) {

Original file line number	Diff line number	Diff line change
`@@ -2696,8 +2696,8 @@ static int mmu_set_spte(struct kvm_vcpu vcpu, struct kvm_memory_slot slot,`
`2696`	`2696`	`if (*sptep == spte) {`
`2697`	`2697`	`ret = RET_PF_SPURIOUS;`
`2698`	`2698`	`} else {`
`2699`		`- trace_kvm_mmu_set_spte(level, gfn, sptep);`
`2700`	`2699`	`flush \|= mmu_spte_update(sptep, spte);`
	`2700`	`+ trace_kvm_mmu_set_spte(level, gfn, sptep);`
`2701`	`2701`	`}`
`2702`	`2702`
`2703`	`2703`	`if (wrprot) {`