thunderbolt: Fix memory leak in tb_handle_dp_bandwidth_request()

westeri · westeri · commit 596a5123cc78 · 2023-08-04T16:17:47.000+03:00
The memory allocated in tb_queue_dp_bandwidth_request() needs to be released once the request is handled to avoid leaking it. Fixes: 6ce3563 ("thunderbolt: Add support for DisplayPort bandwidth allocation mode") Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
@@ -1964,6 +1964,8 @@ static void tb_handle_dp_bandwidth_request(struct work_struct *work)
 
 	pm_runtime_mark_last_busy(&tb->dev);
 	pm_runtime_put_autosuspend(&tb->dev);
+
+	kfree(ev);
 }
 
 static void tb_queue_dp_bandwidth_request(struct tb *tb, u64 route, u8 port)

Original file line number	Diff line number	Diff line change
`@@ -1964,6 +1964,8 @@ static void tb_handle_dp_bandwidth_request(struct work_struct *work)`
`1964`	`1964`
`1965`	`1965`	`pm_runtime_mark_last_busy(&tb->dev);`
`1966`	`1966`	`pm_runtime_put_autosuspend(&tb->dev);`
	`1967`	`+`
	`1968`	`+ kfree(ev);`
`1967`	`1969`	`}`
`1968`	`1970`
`1969`	`1971`	`static void tb_queue_dp_bandwidth_request(struct tb *tb, u64 route, u8 port)`