Skip to content

Commit 5975e25

Browse files
saketbhaskarshuahkh
authored andcommitted
tools/cpupower: Choose base_cpu to display default cpupower details
The default output of cpupower info utils shows unexpected output when CPU 0 is disabled. Considering a case where CPU 0 is disabled, output of cpupower idle-info: Before change: cpupower idle-info CPUidle driver: pseries_idle CPUidle governor: menu analyzing CPU 0: *is offline After change: ./cpupower idle-info CPUidle driver: pseries_idle CPUidle governor: menu analyzing CPU 50: Number of idle states: 2 Available idle states: snooze CEDE snooze: Flags/Description: snooze Latency: 0 Usage: 101748 Duration: 2724058 CEDE: Flags/Description: CEDE Latency: 12 Usage: 270004 Duration: 283019526849 If -c option is not passed, CPU 0 was chosen as the default chosen CPU to display details. However when CPU 0 is offline, it results in showing unexpected output. This commit chooses the base_cpu instead of CPU 0, hence keeping the output more relevant in all cases. The base_cpu is the number of CPU on which the calling thread is currently executing. Signed-off-by: Saket Kumar Bhaskar <skb99@linux.vnet.ibm.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent 9abf231 commit 5975e25

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

tools/power/cpupower/utils/cpufreq-info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,9 +572,9 @@ int cmd_freq_info(int argc, char **argv)
572572

573573
ret = 0;
574574

575-
/* Default is: show output of CPU 0 only */
575+
/* Default is: show output of base_cpu only */
576576
if (bitmask_isallclear(cpus_chosen))
577-
bitmask_setbit(cpus_chosen, 0);
577+
bitmask_setbit(cpus_chosen, base_cpu);
578578

579579
switch (output_param) {
580580
case -1:

tools/power/cpupower/utils/cpuidle-info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ int cmd_idle_info(int argc, char **argv)
176176
cpuidle_exit(EXIT_FAILURE);
177177
}
178178

179-
/* Default is: show output of CPU 0 only */
179+
/* Default is: show output of base_cpu only */
180180
if (bitmask_isallclear(cpus_chosen))
181-
bitmask_setbit(cpus_chosen, 0);
181+
bitmask_setbit(cpus_chosen, base_cpu);
182182

183183
if (output_param == 0)
184184
cpuidle_general_output();

tools/power/cpupower/utils/cpupower-info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ int cmd_info(int argc, char **argv)
6767
if (!params.params)
6868
params.params = 0x7;
6969

70-
/* Default is: show output of CPU 0 only */
70+
/* Default is: show output of base_cpu only */
7171
if (bitmask_isallclear(cpus_chosen))
72-
bitmask_setbit(cpus_chosen, 0);
72+
bitmask_setbit(cpus_chosen, base_cpu);
7373

7474
/* Add more per cpu options here */
7575
if (!params.perf_bias)

0 commit comments

Comments
 (0)