pwm: adp5585: Set OSC_EN bit to 1 when PWM state is enabled

Liu Ying · Uwe Kleine-König · commit 59921a739707 · 2024-09-16T15:24:58.000+02:00
It turns out that OSC_EN bit in GERNERAL_CFG register has to be set to 1 when PWM state is enabled, otherwise PWM signal won't be generated. Fixes: e9b5038 ("pwm: adp5585: Add Analog Devices ADP5585 support") Signed-off-by: Liu Ying <victor.liu@nxp.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://lore.kernel.org/r/20240826083337.1835405-1-victor.liu@nxp.com Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c
@@ -100,6 +100,10 @@ static int pwm_adp5585_apply(struct pwm_chip *chip,
 	if (ret)
 		return ret;
 
+	ret = regmap_set_bits(regmap, ADP5585_GENERAL_CFG, ADP5585_OSC_EN);
+	if (ret)
+		return ret;
+
 	return regmap_set_bits(regmap, ADP5585_PWM_CFG, ADP5585_PWM_EN);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,10 @@ static int pwm_adp5585_apply(struct pwm_chip *chip,`
`100`	`100`	`if (ret)`
`101`	`101`	`return ret;`
`102`	`102`
	`103`	`+ ret = regmap_set_bits(regmap, ADP5585_GENERAL_CFG, ADP5585_OSC_EN);`
	`104`	`+ if (ret)`
	`105`	`+ return ret;`
	`106`	`+`
`103`	`107`	`return regmap_set_bits(regmap, ADP5585_PWM_CFG, ADP5585_PWM_EN);`
`104`	`108`	`}`
`105`	`109`