Skip to content

Commit 59a61e6

Browse files
Yang Yingliangalexandrebelloni
authored andcommitted
i3c: master: svc: drop free_irq of devm_request_irq allocated irq
irq allocated with devm_request_irq() will be freed in devm_irq_release(), using free_irq() in ->remove() will causes a dangling pointer, and a subsequent double free. So remove the free_irq() in svc_i3c_master_remove(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20210602084935.3977636-1-yangyingliang@huawei.com
1 parent 6efb943 commit 59a61e6

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/i3c/master/svc-i3c-master.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1448,7 +1448,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev)
14481448
if (ret)
14491449
return ret;
14501450

1451-
free_irq(master->irq, master);
14521451
clk_disable_unprepare(master->pclk);
14531452
clk_disable_unprepare(master->fclk);
14541453
clk_disable_unprepare(master->sclk);

0 commit comments

Comments
 (0)