Skip to content

Commit 59e45c7

Browse files
Alexander Aringteigland
authored andcommitted
fs: dlm: interrupt posix locks only when process is killed
If a posix lock request is waiting for a result from user space (dlm_controld), do not let it be interrupted unless the process is killed. This reverts commit a6b1533 ("dlm: make posix locks interruptible"). The problem with the interruptible change is that all locks were cleared on any signal interrupt. If a signal was received that did not terminate the process, the process could continue running after all its dlm posix locks had been cleared. A future patch will add cancelation to allow proper interruption. Cc: stable@vger.kernel.org Fixes: a6b1533 ("dlm: make posix locks interruptible") Signed-off-by: Alexander Aring <aahringo@redhat.com> Signed-off-by: David Teigland <teigland@redhat.com>
1 parent c847f4e commit 59e45c7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/dlm/plock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file,
155155

156156
send_op(op);
157157

158-
rv = wait_event_interruptible(recv_wq, (op->done != 0));
158+
rv = wait_event_killable(recv_wq, (op->done != 0));
159159
if (rv == -ERESTARTSYS) {
160160
spin_lock(&ops_lock);
161161
/* recheck under ops_lock if we got a done != 0,

0 commit comments

Comments
 (0)