ALSA: seq: remove redundant unsigned comparison to zero

Wang Weiyang · tiwai · commit 59ea9138c075 · 2023-07-21T13:02:16.000+02:00
Since struct snd_ump_block_info::first_group is unsigned char, comparison to zero is redundant Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com> Fixes: 81fd444 ("ALSA: seq: Bind UMP device") Link: https://lore.kernel.org/r/20230721103124.18522-1-wangweiyang2@huawei.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/core/seq/seq_ump_client.c b/sound/core/seq/seq_ump_client.c
@@ -298,8 +298,7 @@ static void update_group_attrs(struct seq_ump_client *client)
 	}
 
 	list_for_each_entry(fb, &client->ump->block_list, list) {
-		if (fb->info.first_group < 0 ||
-		    fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)
+		if (fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)
 			break;
 		group = &client->groups[fb->info.first_group];
 		for (i = 0; i < fb->info.num_groups; i++, group++) {

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,7 @@ static void update_group_attrs(struct seq_ump_client *client)`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`list_for_each_entry(fb, &client->ump->block_list, list) {`
`301`		`- if (fb->info.first_group < 0 \|\|`
`302`		`- fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)`
	`301`	`+ if (fb->info.first_group + fb->info.num_groups > SNDRV_UMP_MAX_GROUPS)`
`303`	`302`	`break;`
`304`	`303`	`group = &client->groups[fb->info.first_group];`
`305`	`304`	`for (i = 0; i < fb->info.num_groups; i++, group++) {`