Skip to content

Commit 5a35770

Browse files
mcgrofgregkh
authored andcommitted
firmware_loader: revert removal of the fw_fallback_config export
Christoph's patch removed two unsused exported symbols, however, one symbol is used by the firmware_loader itself. If CONFIG_FW_LOADER=m so the firmware_loader is modular but CONFIG_FW_LOADER_USER_HELPER=y we fail the build at mostpost. ERROR: modpost: "fw_fallback_config" [drivers/base/firmware_loader/firmware_class.ko] undefined! This happens because the variable fw_fallback_config is built into the kernel if CONFIG_FW_LOADER_USER_HELPER=y always, so we need to grant access to the firmware loader module by exporting it. Revert only one hunk from his patch. Fixes: 7396047 ("firmware_loader: remove unused exports") Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> Link: https://lore.kernel.org/r/20200424184916.22843-1-mcgrof@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2b07021 commit 5a35770

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/base/firmware_loader/fallback_table.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ struct firmware_fallback_config fw_fallback_config = {
2121
.loading_timeout = 60,
2222
.old_timeout = 60,
2323
};
24+
EXPORT_SYMBOL_GPL(fw_fallback_config);
2425

2526
#ifdef CONFIG_SYSCTL
2627
struct ctl_table firmware_config_table[] = {

0 commit comments

Comments
 (0)