Skip to content

Commit 5aa39a9

Browse files
committed
cxl/port: Rename CXL_DECODER_{EXPANDER, ACCELERATOR} => {HOSTONLYMEM, DEVMEM}
In preparation for support for HDM-D and HDM-DB configuration (device-memory, and device-memory with back-invalidate). Rename the current type designators to use HOSTONLYMEM and DEVMEM as a suffix. HDM-DB can be supported by devices that are not accelerators, so DEVMEM is a more generic term for that case. Fixup one location where this type value was open coded. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/168679261369.3436160.7042443847605280593.stgit@dwillia2-xfh.jf.intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent f6b8ab3 commit 5aa39a9

6 files changed

Lines changed: 16 additions & 15 deletions

File tree

drivers/cxl/acpi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
258258

259259
cxld = &cxlrd->cxlsd.cxld;
260260
cxld->flags = cfmws_to_decoder_flags(cfmws->restrictions);
261-
cxld->target_type = CXL_DECODER_EXPANDER;
261+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
262262
cxld->hpa_range = (struct range) {
263263
.start = res->start,
264264
.end = res->end,

drivers/cxl/core/hdm.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,8 @@ static void cxld_set_interleave(struct cxl_decoder *cxld, u32 *ctrl)
570570

571571
static void cxld_set_type(struct cxl_decoder *cxld, u32 *ctrl)
572572
{
573-
u32p_replace_bits(ctrl, !!(cxld->target_type == 3),
573+
u32p_replace_bits(ctrl,
574+
!!(cxld->target_type == CXL_DECODER_HOSTONLYMEM),
574575
CXL_HDM_DECODER0_CTRL_TYPE);
575576
}
576577

@@ -764,7 +765,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
764765
if (!len)
765766
return -ENOENT;
766767

767-
cxld->target_type = CXL_DECODER_EXPANDER;
768+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
768769
cxld->commit = NULL;
769770
cxld->reset = NULL;
770771
cxld->hpa_range = info->dvsec_range[which];
@@ -838,9 +839,9 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
838839
if (ctrl & CXL_HDM_DECODER0_CTRL_LOCK)
839840
cxld->flags |= CXL_DECODER_F_LOCK;
840841
if (FIELD_GET(CXL_HDM_DECODER0_CTRL_TYPE, ctrl))
841-
cxld->target_type = CXL_DECODER_EXPANDER;
842+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
842843
else
843-
cxld->target_type = CXL_DECODER_ACCELERATOR;
844+
cxld->target_type = CXL_DECODER_DEVMEM;
844845
if (cxld->id != port->commit_end + 1) {
845846
dev_warn(&port->dev,
846847
"decoder%d.%d: Committed out of order\n",
@@ -861,7 +862,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
861862
ctrl |= CXL_HDM_DECODER0_CTRL_TYPE;
862863
writel(ctrl, hdm + CXL_HDM_DECODER0_CTRL_OFFSET(which));
863864
}
864-
cxld->target_type = CXL_DECODER_EXPANDER;
865+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
865866
}
866867
rc = eiw_to_ways(FIELD_GET(CXL_HDM_DECODER0_CTRL_IW_MASK, ctrl),
867868
&cxld->interleave_ways);

drivers/cxl/core/port.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ static ssize_t target_type_show(struct device *dev,
117117
struct cxl_decoder *cxld = to_cxl_decoder(dev);
118118

119119
switch (cxld->target_type) {
120-
case CXL_DECODER_ACCELERATOR:
120+
case CXL_DECODER_DEVMEM:
121121
return sysfs_emit(buf, "accelerator\n");
122-
case CXL_DECODER_EXPANDER:
122+
case CXL_DECODER_HOSTONLYMEM:
123123
return sysfs_emit(buf, "expander\n");
124124
}
125125
return -ENXIO;
@@ -1550,7 +1550,7 @@ static int cxl_decoder_init(struct cxl_port *port, struct cxl_decoder *cxld)
15501550
/* Pre initialize an "empty" decoder */
15511551
cxld->interleave_ways = 1;
15521552
cxld->interleave_granularity = PAGE_SIZE;
1553-
cxld->target_type = CXL_DECODER_EXPANDER;
1553+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
15541554
cxld->hpa_range = (struct range) {
15551555
.start = 0,
15561556
.end = -1,

drivers/cxl/core/region.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2103,7 +2103,7 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,
21032103
return ERR_PTR(-EBUSY);
21042104
}
21052105

2106-
return devm_cxl_add_region(cxlrd, id, mode, CXL_DECODER_EXPANDER);
2106+
return devm_cxl_add_region(cxlrd, id, mode, CXL_DECODER_HOSTONLYMEM);
21072107
}
21082108

21092109
static ssize_t create_pmem_region_store(struct device *dev,

drivers/cxl/cxl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,8 @@ resource_size_t cxl_rcrb_to_component(struct device *dev,
290290
#define CXL_DECODER_F_MASK GENMASK(5, 0)
291291

292292
enum cxl_decoder_type {
293-
CXL_DECODER_ACCELERATOR = 2,
294-
CXL_DECODER_EXPANDER = 3,
293+
CXL_DECODER_DEVMEM = 2,
294+
CXL_DECODER_HOSTONLYMEM = 3,
295295
};
296296

297297
/*

tools/testing/cxl/test/cxl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ static void default_mock_decoder(struct cxl_decoder *cxld)
713713

714714
cxld->interleave_ways = 1;
715715
cxld->interleave_granularity = 256;
716-
cxld->target_type = CXL_DECODER_EXPANDER;
716+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
717717
cxld->commit = mock_decoder_commit;
718718
cxld->reset = mock_decoder_reset;
719719
}
@@ -787,7 +787,7 @@ static void mock_init_hdm_decoder(struct cxl_decoder *cxld)
787787

788788
cxld->interleave_ways = 2;
789789
eig_to_granularity(window->granularity, &cxld->interleave_granularity);
790-
cxld->target_type = CXL_DECODER_EXPANDER;
790+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
791791
cxld->flags = CXL_DECODER_F_ENABLE;
792792
cxled->state = CXL_DECODER_STATE_AUTO;
793793
port->commit_end = cxld->id;
@@ -820,7 +820,7 @@ static void mock_init_hdm_decoder(struct cxl_decoder *cxld)
820820
} else
821821
cxlsd->target[0] = dport;
822822
cxld = &cxlsd->cxld;
823-
cxld->target_type = CXL_DECODER_EXPANDER;
823+
cxld->target_type = CXL_DECODER_HOSTONLYMEM;
824824
cxld->flags = CXL_DECODER_F_ENABLE;
825825
iter->commit_end = 0;
826826
/*

0 commit comments

Comments
 (0)