Skip to content

Commit 5c88705

Browse files
committed
netfs: Adjust the netfs_failure tracepoint to indicate non-subreq lines
Adjust the netfs_failure tracepoint to indicate a subrequest number of -1 when it's a full-request failure unrelated to any particular subrequest, such as a failure to encrypt its data buffer. Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> cc: linux-cachefs@redhat.com Link: https://lore.kernel.org/r/164623001948.3564931.2353852999649380059.stgit@warthog.procyon.org.uk/ # v1 Link: https://lore.kernel.org/r/164678204587.1200972.14893513018190383961.stgit@warthog.procyon.org.uk/ # v2 Link: https://lore.kernel.org/r/164692903233.2099075.15414355147237641274.stgit@warthog.procyon.org.uk/ # v3
1 parent 6cd3d6f commit 5c88705

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

include/trace/events/netfs.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ TRACE_EVENT(netfs_failure,
222222

223223
TP_STRUCT__entry(
224224
__field(unsigned int, rreq )
225-
__field(unsigned short, index )
225+
__field(short, index )
226226
__field(short, error )
227227
__field(unsigned short, flags )
228228
__field(enum netfs_io_source, source )
@@ -234,17 +234,17 @@ TRACE_EVENT(netfs_failure,
234234

235235
TP_fast_assign(
236236
__entry->rreq = rreq->debug_id;
237-
__entry->index = sreq ? sreq->debug_index : 0;
237+
__entry->index = sreq ? sreq->debug_index : -1;
238238
__entry->error = error;
239239
__entry->flags = sreq ? sreq->flags : 0;
240240
__entry->source = sreq ? sreq->source : NETFS_INVALID_READ;
241241
__entry->what = what;
242-
__entry->len = sreq ? sreq->len : 0;
242+
__entry->len = sreq ? sreq->len : rreq->len;
243243
__entry->transferred = sreq ? sreq->transferred : 0;
244244
__entry->start = sreq ? sreq->start : 0;
245245
),
246246

247-
TP_printk("R=%08x[%u] %s f=%02x s=%llx %zx/%zx %s e=%d",
247+
TP_printk("R=%08x[%d] %s f=%02x s=%llx %zx/%zx %s e=%d",
248248
__entry->rreq, __entry->index,
249249
__print_symbolic(__entry->source, netfs_sreq_sources),
250250
__entry->flags,

0 commit comments

Comments
 (0)