drm: simpledrm: fix wrong unit with pixel clock

asconcepcion · tdz · commit 5cf06065bd1f · 2021-12-13T11:25:06.000+01:00
Pixel clock has to be set in kHz. Signed-off-by: Alejandro Concepcion-Rodriguez <asconcepcion@acoro.eu> Fixes: 11e8f5f ("drm: Add simpledrm driver") Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/6f8554ef-1305-0dda-821c-f7d2e5644a48@acoro.eu
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
@@ -458,7 +458,7 @@ static struct drm_display_mode simpledrm_mode(unsigned int width,
 {
 	struct drm_display_mode mode = { SIMPLEDRM_MODE(width, height) };
 
-	mode.clock = 60 /* Hz */ * mode.hdisplay * mode.vdisplay;
+	mode.clock = mode.hdisplay * mode.vdisplay * 60 / 1000 /* kHz */;
 	drm_mode_set_name(&mode);
 
 	return mode;

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ static struct drm_display_mode simpledrm_mode(unsigned int width,`
`458`	`458`	`{`
`459`	`459`	`struct drm_display_mode mode = { SIMPLEDRM_MODE(width, height) };`
`460`	`460`
`461`		`- mode.clock = 60 /* Hz / mode.hdisplay * mode.vdisplay;`
	`461`	`+ mode.clock = mode.hdisplay * mode.vdisplay * 60 / 1000 /* kHz */;`
`462`	`462`	`drm_mode_set_name(&mode);`
`463`	`463`
`464`	`464`	`return mode;`