Skip to content

Commit 5df1a5d

Browse files
committed
ASoC: mt8192: Remove spammy log messages
There are a lot of info level log messages in the mt8192 ADDA driver which are trivially triggerable from userspace, many in normal operation. Remove these to avoid spamming the console. Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20230223-asoc-mt8192-quick-fixes-v1-1-9a85f90368e1@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fb1847c commit 5df1a5d

1 file changed

Lines changed: 0 additions & 33 deletions

File tree

sound/soc/mediatek/mt8192/mt8192-dai-adda.c

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -303,9 +303,6 @@ static int mtk_adda_ul_event(struct snd_soc_dapm_widget *w,
303303
struct mt8192_afe_private *afe_priv = afe->platform_priv;
304304
int mtkaif_dmic = afe_priv->mtkaif_dmic;
305305

306-
dev_info(afe->dev, "%s(), name %s, event 0x%x, mtkaif_dmic %d\n",
307-
__func__, w->name, event, mtkaif_dmic);
308-
309306
switch (event) {
310307
case SND_SOC_DAPM_PRE_PMU:
311308
mt8192_afe_gpio_request(afe->dev, true, MT8192_DAI_ADDA, 1);
@@ -345,10 +342,6 @@ static int mtk_adda_ch34_ul_event(struct snd_soc_dapm_widget *w,
345342
int mtkaif_dmic = afe_priv->mtkaif_dmic_ch34;
346343
int mtkaif_adda6_only = afe_priv->mtkaif_adda6_only;
347344

348-
dev_info(afe->dev,
349-
"%s(), name %s, event 0x%x, mtkaif_dmic %d, mtkaif_adda6_only %d\n",
350-
__func__, w->name, event, mtkaif_dmic, mtkaif_adda6_only);
351-
352345
switch (event) {
353346
case SND_SOC_DAPM_PRE_PMU:
354347
mt8192_afe_gpio_request(afe->dev, true, MT8192_DAI_ADDA_CH34,
@@ -538,9 +531,6 @@ static int mtk_adda_dl_event(struct snd_soc_dapm_widget *w,
538531
struct snd_soc_component *cmpnt = snd_soc_dapm_to_component(w->dapm);
539532
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
540533

541-
dev_info(afe->dev, "%s(), name %s, event 0x%x\n",
542-
__func__, w->name, event);
543-
544534
switch (event) {
545535
case SND_SOC_DAPM_PRE_PMU:
546536
mt8192_afe_gpio_request(afe->dev, true, MT8192_DAI_ADDA, 0);
@@ -564,9 +554,6 @@ static int mtk_adda_ch34_dl_event(struct snd_soc_dapm_widget *w,
564554
struct snd_soc_component *cmpnt = snd_soc_dapm_to_component(w->dapm);
565555
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
566556

567-
dev_info(afe->dev, "%s(), name %s, event 0x%x\n",
568-
__func__, w->name, event);
569-
570557
switch (event) {
571558
case SND_SOC_DAPM_PRE_PMU:
572559
mt8192_afe_gpio_request(afe->dev, true, MT8192_DAI_ADDA_CH34,
@@ -612,9 +599,6 @@ static int stf_positive_gain_set(struct snd_kcontrol *kcontrol,
612599
AFE_SIDETONE_GAIN,
613600
POSITIVE_GAIN_MASK_SFT,
614601
(gain_db / 6) << POSITIVE_GAIN_SFT);
615-
} else {
616-
dev_warn(afe->dev, "%s(), gain_db %d invalid\n",
617-
__func__, gain_db);
618602
}
619603
return 0;
620604
}
@@ -640,9 +624,6 @@ static int mt8192_adda_dmic_set(struct snd_kcontrol *kcontrol,
640624

641625
dmic_on = ucontrol->value.integer.value[0];
642626

643-
dev_info(afe->dev, "%s(), kcontrol name %s, dmic_on %d\n",
644-
__func__, kcontrol->id.name, dmic_on);
645-
646627
afe_priv->mtkaif_dmic = dmic_on;
647628
afe_priv->mtkaif_dmic_ch34 = dmic_on;
648629
return 0;
@@ -669,9 +650,6 @@ static int mt8192_adda6_only_set(struct snd_kcontrol *kcontrol,
669650

670651
mtkaif_adda6_only = ucontrol->value.integer.value[0];
671652

672-
dev_info(afe->dev, "%s(), kcontrol name %s, mtkaif_adda6_only %d\n",
673-
__func__, kcontrol->id.name, mtkaif_adda6_only);
674-
675653
afe_priv->mtkaif_adda6_only = mtkaif_adda6_only;
676654
return 0;
677655
}
@@ -750,9 +728,6 @@ static int mtk_stf_event(struct snd_soc_dapm_widget *w,
750728

751729
regmap_read(afe->regmap, AFE_SIDETONE_CON1, &reg_value);
752730

753-
dev_info(afe->dev, "%s(), name %s, event 0x%x, ul_rate 0x%x, AFE_SIDETONE_CON1 0x%x\n",
754-
__func__, w->name, event, ul_rate, reg_value);
755-
756731
switch (event) {
757732
case SND_SOC_DAPM_PRE_PMU:
758733
/* set side tone gain = 0 */
@@ -1163,12 +1138,6 @@ static int mtk_dai_adda_hw_params(struct snd_pcm_substream *substream,
11631138
unsigned int rate = params_rate(params);
11641139
int id = dai->id;
11651140

1166-
dev_info(afe->dev, "%s(), id %d, stream %d, rate %d\n",
1167-
__func__,
1168-
id,
1169-
substream->stream,
1170-
rate);
1171-
11721141
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
11731142
unsigned int dl_src2_con0 = 0;
11741143
unsigned int dl_src2_con1 = 0;
@@ -1441,8 +1410,6 @@ int mt8192_dai_adda_register(struct mtk_base_afe *afe)
14411410
struct mtk_base_afe_dai *dai;
14421411
struct mt8192_afe_private *afe_priv = afe->platform_priv;
14431412

1444-
dev_info(afe->dev, "%s()\n", __func__);
1445-
14461413
dai = devm_kzalloc(afe->dev, sizeof(*dai), GFP_KERNEL);
14471414
if (!dai)
14481415
return -ENOMEM;

0 commit comments

Comments
 (0)