Skip to content

Commit 5e74a4b

Browse files
tititiou36Paolo Abeni
authored andcommitted
stmmac: intel: Fix an error handling path in intel_eth_pci_probe()
When the managed API is used, there is no need to explicitly call pci_free_irq_vectors(). This looks to be a left-over from the commit in the Fixes tag. Only the .remove() function had been updated. So remove this unused function call and update goto label accordingly. Fixes: 8accc46 ("stmmac: intel: use managed PCI function on probe and resume") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Wong Vee Khee <vee.khee.wong@linux.intel.com> Link: https://lore.kernel.org/r/1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent b8d9139 commit 5e74a4b

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,13 +1072,11 @@ static int intel_eth_pci_probe(struct pci_dev *pdev,
10721072

10731073
ret = stmmac_dvr_probe(&pdev->dev, plat, &res);
10741074
if (ret) {
1075-
goto err_dvr_probe;
1075+
goto err_alloc_irq;
10761076
}
10771077

10781078
return 0;
10791079

1080-
err_dvr_probe:
1081-
pci_free_irq_vectors(pdev);
10821080
err_alloc_irq:
10831081
clk_disable_unprepare(plat->stmmac_clk);
10841082
clk_unregister_fixed_rate(plat->stmmac_clk);

0 commit comments

Comments
 (0)