Skip to content

Commit 5e88d1a

Browse files
committed
erofs: use credential guards
Use credential guards for scoped credential override with automatic restoration on scope exit. Link: https://patch.msgid.link/20251103-work-creds-guards-simple-v1-9-a3e156839e7f@kernel.org Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent ff2044c commit 5e88d1a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

fs/erofs/fileio.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ static void erofs_fileio_ki_complete(struct kiocb *iocb, long ret)
4747

4848
static void erofs_fileio_rq_submit(struct erofs_fileio_rq *rq)
4949
{
50-
const struct cred *old_cred;
5150
struct iov_iter iter;
5251
int ret;
5352

@@ -61,9 +60,8 @@ static void erofs_fileio_rq_submit(struct erofs_fileio_rq *rq)
6160
rq->iocb.ki_flags = IOCB_DIRECT;
6261
iov_iter_bvec(&iter, ITER_DEST, rq->bvecs, rq->bio.bi_vcnt,
6362
rq->bio.bi_iter.bi_size);
64-
old_cred = override_creds(rq->iocb.ki_filp->f_cred);
65-
ret = vfs_iocb_iter_read(rq->iocb.ki_filp, &rq->iocb, &iter);
66-
revert_creds(old_cred);
63+
scoped_with_creds(rq->iocb.ki_filp->f_cred)
64+
ret = vfs_iocb_iter_read(rq->iocb.ki_filp, &rq->iocb, &iter);
6765
if (ret != -EIOCBQUEUED)
6866
erofs_fileio_ki_complete(&rq->iocb, ret);
6967
}

0 commit comments

Comments
 (0)