Skip to content

Commit 5eb6360

Browse files
ij-intelshuahkh
authored andcommitted
selftests/resctrl: Correct benchmark command help
Benchmark command must be the last argument because it consumes all the remaining arguments but help misleadingly shows it as the first argument. The benchmark command is also shown in quotes but it does not match with the code. Correct -b argument place in the help message and remove the quotes. Tweak also how the options are presented by using ... notation. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Reviewed-by: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent 4a28c76 commit 5eb6360

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/testing/selftests/resctrl/resctrl_tests.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ int get_vendor(void)
5252

5353
static void cmd_help(void)
5454
{
55-
printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
56-
printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");
55+
printf("usage: resctrl_tests [-h] [-t test list] [-n no_of_bits] [-b benchmark_cmd [option]...]\n");
56+
printf("\t-b benchmark_cmd [option]...: run specified benchmark for MBM, MBA and CMT\n");
5757
printf("\t default benchmark is builtin fill_buf\n");
5858
printf("\t-t test list: run tests specified in the test list, ");
5959
printf("e.g. -t mbm,mba,cmt,cat\n");

0 commit comments

Comments
 (0)