Skip to content

Commit 5eeebfe

Browse files
peilin-yekuba-moo
authored andcommitted
net/sched: sch_clsact: Only create under TC_H_CLSACT
clsact Qdiscs are only supposed to be created under TC_H_CLSACT (which equals TC_H_INGRESS). Return -EOPNOTSUPP if 'parent' is not TC_H_CLSACT. Fixes: 1f211a1 ("net, sched: add clsact qdisc") Tested-by: Pedro Tammela <pctammela@mojatatu.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com> Reviewed-by: Vlad Buslov <vladbu@nvidia.com> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent c7cfbd1 commit 5eeebfe

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

net/sched/sch_ingress.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,9 @@ static int clsact_init(struct Qdisc *sch, struct nlattr *opt,
225225
struct net_device *dev = qdisc_dev(sch);
226226
int err;
227227

228+
if (sch->parent != TC_H_CLSACT)
229+
return -EOPNOTSUPP;
230+
228231
net_inc_ingress_queue();
229232
net_inc_egress_queue();
230233

@@ -254,6 +257,9 @@ static void clsact_destroy(struct Qdisc *sch)
254257
{
255258
struct clsact_sched_data *q = qdisc_priv(sch);
256259

260+
if (sch->parent != TC_H_CLSACT)
261+
return;
262+
257263
tcf_block_put_ext(q->egress_block, sch, &q->egress_block_info);
258264
tcf_block_put_ext(q->ingress_block, sch, &q->ingress_block_info);
259265

0 commit comments

Comments
 (0)