regulator: pca9450: Fix return value when failing to get sd-vsel GPIO

fschrempf · broonie · commit 5fe5f17dc59e · 2021-03-10T12:22:23.000Z
This fixes the return value of pca9450_i2c_probe() to use the correct error code when getting the sd-vsel GPIO fails. Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> Link: https://lore.kernel.org/r/20210222150809.208942-1-frieder.schrempf@kontron.de Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
@@ -814,7 +814,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c,
 
 	if (IS_ERR(pca9450->sd_vsel_gpio)) {
 		dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
-		return ret;
+		return PTR_ERR(pca9450->sd_vsel_gpio);
 	}
 
 	dev_info(&i2c->dev, "%s probed.\n",

Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c,`
`814`	`814`
`815`	`815`	`if (IS_ERR(pca9450->sd_vsel_gpio)) {`
`816`	`816`	`dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");`
`817`		`- return ret;`
	`817`	`+ return PTR_ERR(pca9450->sd_vsel_gpio);`
`818`	`818`	`}`
`819`	`819`
`820`	`820`	`dev_info(&i2c->dev, "%s probed.\n",`