Skip to content

Commit 5ff5505

Browse files
nfrapradorobertfoss
authored andcommitted
drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 623a353 ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-8-619a28148e5c@collabora.com
1 parent 24f4f57 commit 5ff5505

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/gpu/drm/panel/panel-novatek-nt35950.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -556,10 +556,8 @@ static int nt35950_probe(struct mipi_dsi_device *dsi)
556556
}
557557
dsi_r_host = of_find_mipi_dsi_host_by_node(dsi_r);
558558
of_node_put(dsi_r);
559-
if (!dsi_r_host) {
560-
dev_err(dev, "Cannot get secondary DSI host\n");
561-
return -EPROBE_DEFER;
562-
}
559+
if (!dsi_r_host)
560+
return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n");
563561

564562
nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);
565563
if (!nt->dsi[1]) {

0 commit comments

Comments
 (0)