Skip to content

Commit 60386b8

Browse files
robertosassumimizohar
authored andcommitted
ima: Don't ignore errors from crypto_shash_update()
Errors returned by crypto_shash_update() are not checked in ima_calc_boot_aggregate_tfm() and thus can be overwritten at the next iteration of the loop. This patch adds a check after calling crypto_shash_update() and returns immediately if the result is not zero. Cc: stable@vger.kernel.org Fixes: 3323eec ("integrity: IMA as an integrity service provider") Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
1 parent f60c826 commit 60386b8

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

security/integrity/ima/ima_crypto.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,8 @@ static int ima_calc_boot_aggregate_tfm(char *digest, u16 alg_id,
829829
/* now accumulate with current aggregate */
830830
rc = crypto_shash_update(shash, d.digest,
831831
crypto_shash_digestsize(tfm));
832+
if (rc != 0)
833+
return rc;
832834
}
833835
/*
834836
* Extend cumulative digest over TPM registers 8-9, which contain

0 commit comments

Comments
 (0)