Skip to content

Commit 60a031b

Browse files
arndbmchehab
authored andcommitted
media: i2c: thp7312: select CONFIG_FW_LOADER
The recently added driver uses the firmware loader mechanism but causes a link failure when that is in a loadable module while thp7312 itself is built-in: arm-linux-gnueabi-ld: drivers/media/i2c/thp7312.o: in function `thp7312_probe': thp7312.c:(.text+0x4164): undefined reference to `firmware_upload_register' Select the required Kconfig symbol. Note that the driver specifically needs the firmware upload interface that is controlled by CONFIG_FW_UPLOAD, but there is no link failure when that is disabled because the interfaces are stubbed out here. Link: https://lore.kernel.org/linux-media/20240103155811.4092035-1-arnd@kernel.org Fixes: 7a52ab4 ("media: i2c: Add driver for THine THP7312") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent 02d4e62 commit 60a031b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/media/i2c/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,7 @@ menu "Camera ISPs"
674674
config VIDEO_THP7312
675675
tristate "THine THP7312 support"
676676
depends on I2C
677+
select FW_LOADER
677678
select MEDIA_CONTROLLER
678679
select V4L2_CCI_I2C
679680
select V4L2_FWNODE

0 commit comments

Comments
 (0)