Skip to content

Commit 610323d

Browse files
Jakob-Koschelhdeller
authored andcommitted
video: fbdev: mmp: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1] Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent c40b653 commit 610323d

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

drivers/video/fbdev/mmp/core.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
127127
*/
128128
struct mmp_path *mmp_get_path(const char *name)
129129
{
130-
struct mmp_path *path;
131-
int found = 0;
130+
struct mmp_path *path = NULL, *iter;
132131

133132
mutex_lock(&disp_lock);
134-
list_for_each_entry(path, &path_list, node) {
135-
if (!strcmp(name, path->name)) {
136-
found = 1;
133+
list_for_each_entry(iter, &path_list, node) {
134+
if (!strcmp(name, iter->name)) {
135+
path = iter;
137136
break;
138137
}
139138
}
140139
mutex_unlock(&disp_lock);
141140

142-
return found ? path : NULL;
141+
return path;
143142
}
144143
EXPORT_SYMBOL_GPL(mmp_get_path);
145144

0 commit comments

Comments
 (0)