extcon: extcon-max8997: Fix IRQ freeing at error path

M-Vaittinen · jwrdegoede · commit 610bdc04830a · 2021-06-17T13:22:11.000+02:00
If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits without freeing the requested IRQs. Free the IRQs prior returning if reading the status fails. Fixes: 3e34c81 ("extcon: max8997: Avoid forcing UART path on drive probe") Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Link: https://lore.kernel.org/r/27ee4a48ee775c3f8c9d90459c18b6f2b15edc76.1623146580.git.matti.vaittinen@fi.rohmeurope.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
@@ -733,7 +733,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
 				2, info->status);
 	if (ret) {
 		dev_err(info->dev, "failed to read MUIC register\n");
-		return ret;
+		goto err_irq;
 	}
 	cable_type = max8997_muic_get_cable_type(info,
 					   MAX8997_CABLE_GROUP_ADC, &attached);

Original file line number	Diff line number	Diff line change
`@@ -733,7 +733,7 @@ static int max8997_muic_probe(struct platform_device *pdev)`
`733`	`733`	`2, info->status);`
`734`	`734`	`if (ret) {`
`735`	`735`	`dev_err(info->dev, "failed to read MUIC register\n");`
`736`		`- return ret;`
	`736`	`+ goto err_irq;`
`737`	`737`	`}`
`738`	`738`	`cable_type = max8997_muic_get_cable_type(info,`
`739`	`739`	`MAX8997_CABLE_GROUP_ADC, &attached);`