Skip to content

Commit 615a6e7

Browse files
praveen-pkliuw
authored andcommitted
mshv: Cleanly shutdown root partition with MSHV
Root partitions running on MSHV currently attempt ACPI power-off, which MSHV intercepts and triggers a Machine Check Exception (MCE), leading to a kernel panic. Root partitions panic with a trace similar to: [ 81.306348] reboot: Power down [ 81.314709] mce: [Hardware Error]: CPU 0: Machine Check Exception: 4 Bank 0: b2000000c0060001 [ 81.314711] mce: [Hardware Error]: TSC 3b8cb60a66 PPIN 11d98332458e4ea9 [ 81.314713] mce: [Hardware Error]: PROCESSOR 0:606a6 TIME 1759339405 SOCKET 0 APIC 0 microcode ffffffff [ 81.314715] mce: [Hardware Error]: Run the above through 'mcelog --ascii' [ 81.314716] mce: [Hardware Error]: Machine check: Processor context corrupt [ 81.314717] Kernel panic - not syncing: Fatal machine check To avoid this, configure the sleep state in the hypervisor and invoke the HVCALL_ENTER_SLEEP_STATE hypercall as the final step in the shutdown sequence. This ensures a clean and safe shutdown of the root partition. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com> Co-developed-by: Anatol Belski <anbelski@linux.microsoft.com> Signed-off-by: Anatol Belski <anbelski@linux.microsoft.com> Reviewed-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com> Acked-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com> Signed-off-by: Wei Liu <wei.liu@kernel.org>
1 parent f0be260 commit 615a6e7

3 files changed

Lines changed: 24 additions & 0 deletions

File tree

arch/x86/include/asm/mshyperv.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ int hyperv_fill_flush_guest_mapping_list(
178178
struct hv_guest_mapping_flush_list *flush,
179179
u64 start_gfn, u64 end_gfn);
180180
void hv_sleep_notifiers_register(void);
181+
void hv_machine_power_off(void);
181182

182183
#ifdef CONFIG_X86_64
183184
void hv_apic_init(void);

arch/x86/kernel/cpu/mshyperv.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -621,6 +621,8 @@ static void __init ms_hyperv_init_platform(void)
621621
#endif
622622

623623
#if IS_ENABLED(CONFIG_HYPERV)
624+
if (hv_root_partition())
625+
machine_ops.power_off = hv_machine_power_off;
624626
#if defined(CONFIG_KEXEC_CORE)
625627
machine_ops.shutdown = hv_machine_shutdown;
626628
#endif

drivers/hv/mshv_common.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,3 +216,24 @@ void hv_sleep_notifiers_register(void)
216216
pr_err("%s: cannot register reboot notifier %d\n", __func__,
217217
ret);
218218
}
219+
220+
/*
221+
* Power off the machine by entering S5 sleep state via Hyper-V hypercall.
222+
* This call does not return if successful.
223+
*/
224+
void hv_machine_power_off(void)
225+
{
226+
unsigned long flags;
227+
struct hv_input_enter_sleep_state *in;
228+
229+
local_irq_save(flags);
230+
in = *this_cpu_ptr(hyperv_pcpu_input_arg);
231+
in->sleep_state = HV_SLEEP_STATE_S5;
232+
233+
(void)hv_do_hypercall(HVCALL_ENTER_SLEEP_STATE, in, NULL);
234+
local_irq_restore(flags);
235+
236+
/* should never reach here */
237+
BUG();
238+
239+
}

0 commit comments

Comments
 (0)